Change channel passed to ci_setup to track runtime branch #59071
Conversation
With this change we move to specifing the channel that is passed to ci_setup, instead of it always being main. The allows us to have the runtime branch help decide the correct version of the sdk that we should pull down with dotnet-install. This means that going forward, we will need to have channels that match the names of all branches that we plan to run from the runtime side. If we do not, the sdk installation step will fail during ci_setup.
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsWith this change we move to specifing the channel that is passed to ci_setup,
|
The previous change here broke private runs as it required the channel map to have an entry matching the name of the runtime branch you were testing. This fix now defaults the channel to main for private runs.
|
@jeffschwMSFT PTAL |
There was a problem hiding this comment.
lgtm. @Anipik when is a good time to merge? (this is tell mode infra work)
|
Is this a good time to get merged? This is blocking some people from moving to net7.0. |
|
Neither failure seems related to this change. @Anipik @jeffschwMSFT |
ghost
locked as resolved and limited conversation to collaborators
With this change we move to specifing the channel that is passed to ci_setup,
instead of it always being main. The allows us to have the runtime branch
help decide the correct version of the sdk that we should pull down with
dotnet-install. This means that going forward, we will need to have channels
that match the names of all branches that we plan to run from the runtime
side. If we do not, the sdk installation step will fail during ci_setup.